| commit | 9800ffd1a471582fb42fd782e2e2eeb39dba6c9b | [log] [tgz] |
|---|---|---|
| author | Googler <jhorvitz@google.com> | Tue Apr 04 15:13:41 2023 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Apr 04 15:15:18 2023 -0700 |
| tree | a49e4b9235fb8a5e28deedae9fedc584af29feb2 | |
| parent | 41fd6dd74f6c4970dba53e8115f25b93f48dfe74 [diff] |
Make a rule's `Location` consistent regardless of whether `generator_*` attributes are explicitly set. The logic that detects whether `generator_name` or `generator_function` are already set dates back to python pre-processing and is no longer relevant, but it's still being used by rules that explicitly set one or both of these attributes. Remove this check to ensure that the location is determined consistently: from the outermost frame of the call stack. Deriving the location directly from the call stack opens up the opportunity to avoid storing the `<toplevel>` frame in `CallStack`, since it is the same as the location. Explicitly set `generator_*` attributes seems to happen in practice when attributes are copied from `native.existing_rule`. I will look into whether this can be cleaned up or hand it off if there's a volunteer. RELNOTES: The location of rules that explicitly specify `generator_name` and/or `generator_function` attributes (typically because they are incidentally copied from `native.existing_rule()`) is now the top-level call in the `BUILD` file, which is consistent with rules that do not explicitly specify these attributes. PiperOrigin-RevId: 521878142 Change-Id: Ie8fb7fa9c4bef9137f6e7d7a5c50fb049024a585
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
