Google Git
Sign in
bazel / bazel / 08d691f40bbe8c6ed28a5ba22798f0cbee595fa7
commit08d691f40bbe8c6ed28a5ba22798f0cbee595fa7[log] [tgz]
authorbuchgr <buchgr@google.com>Wed Jun 12 03:04:22 2019 -0700
committerCopybara-Service <copybara-worker@google.com>Wed Jun 12 03:05:14 2019 -0700
treeb37dc85f501552cdde9326a5fd065a54b29d17d8
parent762c25556dceafea5ca6fe2b2c9d575d6cab8125 [diff]
Refactor message construction of ActionExecutionException

Note to Reviewer: Start your review looking at ActionExecutionException.java to see what this change is all about.

The constructor of ActionExecutionException always appends cause.getMessage() to it's own message whenever a cause is available. This behavior is unexpected by a caller and in practice often leads to clunky error messages. I found especially the pattern of new ActionExecutionException(cause.getMessage(), cause) to frequently and unintentionally lead to the duplication of error messages.

This change refactors ActionExecutionException to NOT automatically append cause.getMessage() to it's own message and also fixes relevant callsites to manually append cause.getMessage(). It does not fix the callsites that already call new ActionExecutionException(message, cause.getMessage()) where message.equals(cause.getMessage)) is true. So these callsites unfortunately won't show up as part of this change.

RELNOTES: None
PiperOrigin-RevId: 252790648
16 files changed
tree: b37dc85f501552cdde9326a5fd065a54b29d17d8
  1. .bazelci/
  2. examples/
  3. scripts/
  4. site/
  5. src/
  6. third_party/
  7. tools/
  8. .bazelrc
  9. .gitattributes
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CHANGELOG.md
  14. CODEOWNERS
  15. combine_distfiles.py
  16. combine_distfiles_to_tar.sh
  17. compile.sh
  18. CONTRIBUTING.md
  19. CONTRIBUTORS
  20. distdir.bzl
  21. ISSUE_TEMPLATE.md
  22. LICENSE
  23. README.md
  24. WORKSPACE
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Contributing to Bazel

See CONTRIBUTING.md

Build status

Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.