Let the parent linux-sandbox process move its child process (linux-sandbox-pid1) into the cgroup using the child's non-namespaced pid rather than the child process moving itself into the cgroup with using pid 1. Also, make the cgroup mount readonly to the child linux-sandbox processes (pid1/pid2).

This remedies the following situations:
- Fixes issues in the linux-sandbox when dealing with cgroups mounted at /dev/cgroup (when not using systemd); since cgroups manipulation is now handled by the linux-sandbox parent process, it doesn't matter that the mount is readonly to the child processes.
- This will prevent the linux-sandbox(ed) spawn (process pid2) from being able to overwrite any cgroups files, because we no longer need to (and no longer do) set the cgroup dir as writable to pid1/pid2.

RELNOTES: Prevent linux-sandbox(ed) spawns from being able to write in the cgroups mount.
PiperOrigin-RevId: 597195981
Change-Id: I9975d848498b1ede20b8401343ca7d3c452658a0
6 files changed
tree: 0b99caebd02b1a9025d780863965357a6ceaeb26
  1. .bazelci/
  2. .github/
  3. examples/
  4. scripts/
  5. site/
  6. src/
  7. third_party/
  8. tools/
  9. .bazelrc
  10. .bazelversion
  11. .gitattributes
  12. .gitignore
  13. AUTHORS
  14. bazel_downloader.cfg
  15. BUILD
  16. CHANGELOG.md
  17. CODE_OF_CONDUCT.md
  18. CODEOWNERS
  19. combine_distfiles.py
  20. combine_distfiles_to_tar.sh
  21. compile.sh
  22. CONTRIBUTING.md
  23. CONTRIBUTORS
  24. distdir.bzl
  25. extensions.bzl
  26. LICENSE
  27. maven_install.json
  28. MODULE.bazel
  29. MODULE.bazel.lock
  30. rbe_extension.bzl
  31. README.md
  32. repositories.bzl
  33. requirements.txt
  34. SECURITY.md
  35. WORKSPACE
  36. WORKSPACE.bzlmod
  37. workspace_deps.bzl
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Reporting a Vulnerability

To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.

Contributing to Bazel

See CONTRIBUTING.md

Build status