Update "name" attr doc for all rules to say "target" instead of "rule"
We're historically sloppy with rules vs targets, but it should be inarguable that the result of calling, say, cc_binary, is a target, not a rule. For git.bzl/http.bzl use "repository", instead of either "rule" or "target".
RELNOTES: None
PiperOrigin-RevId: 215786026
diff --git a/src/main/java/com/google/devtools/build/docgen/templates/be/functions.vm b/src/main/java/com/google/devtools/build/docgen/templates/be/functions.vm
index 011a77c..d03c34d 100644
--- a/src/main/java/com/google/devtools/build/docgen/templates/be/functions.vm
+++ b/src/main/java/com/google/devtools/build/docgen/templates/be/functions.vm
@@ -147,7 +147,7 @@
<td id="package_group.name"><code>name</code></td>
<td>
<p><code><a href="../build-ref.html#name">Name</a>; required</code></p>
- <p>A unique name for this rule.</p>
+ <p>A unique name for this target.</p>
</td>
</tr>
<tr>
diff --git a/src/main/java/com/google/devtools/build/docgen/templates/be/rules.vm b/src/main/java/com/google/devtools/build/docgen/templates/be/rules.vm
index 9958a6f..c605fd2 100644
--- a/src/main/java/com/google/devtools/build/docgen/templates/be/rules.vm
+++ b/src/main/java/com/google/devtools/build/docgen/templates/be/rules.vm
@@ -48,7 +48,7 @@
<td id="${rule.ruleName}.name"><code>name</code></td>
<td>
<p><code><a href="../build-ref.html#name">Name</a>; required</code></p>
- <p>A unique name for this rule.</p>
+ <p>A unique name for this target.</p>
${rule.nameExtraHtmlDoc}
</td>
</tr>
diff --git a/src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkRuleFunctionsApi.java b/src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkRuleFunctionsApi.java
index 8f1eb49..8cd428e 100644
--- a/src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkRuleFunctionsApi.java
+++ b/src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkRuleFunctionsApi.java
@@ -47,7 +47,7 @@
public class FakeSkylarkRuleFunctionsApi implements SkylarkRuleFunctionsApi<FileApi> {
private static final FakeDescriptor IMPLICIT_NAME_ATTRIBUTE_DESCRIPTOR =
- new FakeDescriptor(Type.STRING, "A unique name for this rule.", true);
+ new FakeDescriptor(Type.STRING, "A unique name for this target.", true);
private final List<RuleInfo> ruleInfoList;
/**
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/android_basic_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/android_basic_test/golden.txt
index a69252b..402812c 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/android_basic_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/android_basic_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/apple_basic_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/apple_basic_test/golden.txt
index 4cbc0be..6f4b8e7 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/apple_basic_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/apple_basic_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/attribute_types_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/attribute_types_test/golden.txt
index 746e3fe..bb90a54 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/attribute_types_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/attribute_types_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/cpp_basic_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/cpp_basic_test/golden.txt
index ee379d9..7555054 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/cpp_basic_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/cpp_basic_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/filter_rules_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/filter_rules_test/golden.txt
index 457c1b7..6f0d1ca 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/filter_rules_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/filter_rules_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
@@ -65,7 +65,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/java_basic_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/java_basic_test/golden.txt
index 83f6ea4..e1e7356 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/java_basic_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/java_basic_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/golden.txt
index 6ce7cdf..28cd05b 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/multiple_files_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/multiple_files_test/golden.txt
index 771e502..be1e046 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/multiple_files_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/multiple_files_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
@@ -65,7 +65,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
@@ -110,7 +110,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/multiple_rules_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/multiple_rules_test/golden.txt
index 3bf31da..eccbbf4 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/multiple_rules_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/multiple_rules_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
@@ -62,7 +62,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
@@ -104,7 +104,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/same_level_file_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/same_level_file_test/golden.txt
index 72b0116..83d32ab 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/same_level_file_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/same_level_file_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/simple_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/simple_test/golden.txt
index b9f8cec..8a236fe 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/simple_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/simple_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/unknown_name_test/golden.txt b/src/test/java/com/google/devtools/build/skydoc/testdata/unknown_name_test/golden.txt
index 4f78cdf..5490b82 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/unknown_name_test/golden.txt
+++ b/src/test/java/com/google/devtools/build/skydoc/testdata/unknown_name_test/golden.txt
@@ -20,7 +20,7 @@
<td>
String; required
<p>
- A unique name for this rule.
+ A unique name for this target.
</p>
</td>
</tr>
diff --git a/tools/build_defs/repo/git.bzl b/tools/build_defs/repo/git.bzl
index 046fab8..c83141a 100644
--- a/tools/build_defs/repo/git.bzl
+++ b/tools/build_defs/repo/git.bzl
@@ -181,7 +181,7 @@
is).
Args:
- name: A unique name for this rule.
+ name: A unique name for this repository.
build_file: The file to use as the BUILD file for this repository.
Either build_file or build_file_content must be specified.
@@ -242,7 +242,7 @@
Args:
- name: A unique name for this rule.
+ name: A unique name for this repository.
init_submodules: Whether to clone submodules in the repository.
diff --git a/tools/build_defs/repo/http.bzl b/tools/build_defs/repo/http.bzl
index 9336c08..7d1df05 100644
--- a/tools/build_defs/repo/http.bzl
+++ b/tools/build_defs/repo/http.bzl
@@ -181,7 +181,7 @@
Then targets would specify `@my_ssl//:openssl-lib` as a dependency.
Args:
- name: A unique name for this rule.
+ name: A unique name for this repository.
build_file: The file to use as the `BUILD` file for this repository.
Either `build_file` or `build_file_content` can be specified.
@@ -279,7 +279,7 @@
Targets would specify `@my_deb//file` as a dependency to depend on this file.
Args:
- name: A unique name for this rule.
+ name: A unique name for this repository.
executable: If the downloaded file should be made executable. Defaults to
False.
downloaded_file_path: Path assigned to the file downloaded.
@@ -332,7 +332,7 @@
Args:
- name: A unique name for this rule.
+ name: A unique name for this repository.
sha256: The expected SHA-256 of the file downloaded.
url: The URL to fetch the jar from. It must end in `.jar`.
urls: A list of URLS the jar can be fetched from. They have to end in `.jar`.
