commit 0a014e1076fa3feb353e458f35084d41f2dead39
author sxlijin <sxlijin@google.com> Thu May 16 15:08:15 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu May 16 15:09:27 2019 -0700
tree dfb28ac4b1029712fff3609cd6d849f2f1a2feff
parent 3b85bcb96c299f472ba0f24d12f512dbf8b47218

Remove trailing underline from rule links in the overview

Simplify the Velocity template to reduce duplicated code

Add sxlijin@google.com to the list of Bazel contributors

PiperOrigin-RevId: 248608553

src/main/java/com/google/devtools/build/docgen/templates/be/overview.vm

diff --git a/src/main/java/com/google/devtools/build/docgen/templates/be/overview.vm b/src/main/java/com/google/devtools/build/docgen/templates/be/overview.vm
index bb666ca..6930c96 100644
--- a/src/main/java/com/google/devtools/build/docgen/templates/be/overview.vm
+++ b/src/main/java/com/google/devtools/build/docgen/templates/be/overview.vm
@@ -66,46 +66,15 @@
     #if($ruleFamily.size() > 0)
       <tr>
         <td class="lang">${ruleFamily.name}</td>
+      #set( $ruleTypes = [$ruleFamily.binaryRules, $ruleFamily.libraryRules, $ruleFamily.testRules, $ruleFamily.otherRules1, $ruleFamily.otherRules2] )
+      #foreach($ruleType in $ruleTypes)
         <td>
-      #foreach($ruleDoc in $ruleFamily.binaryRules)
-          <a href="#summaryLink(${ruleFamily.id}, ${ruleDoc.ruleName})"#if($ruleDoc.isDeprecated()) class="deprecated"#end>
-            ${ruleDoc.ruleName}
-          </a>
+        #foreach($ruleDoc in $ruleType)
+          <a href="#summaryLink(${ruleFamily.id}, ${ruleDoc.ruleName})"#if($ruleDoc.isDeprecated()) class="deprecated"#end>${ruleDoc.ruleName}</a>
           <br />
-      #end
+        #end
         </td>
-        <td>
-      #foreach($ruleDoc in $ruleFamily.libraryRules)
-          <a href="#summaryLink(${ruleFamily.id}, ${ruleDoc.ruleName})"#if($ruleDoc.isDeprecated()) class="deprecated"#end>
-            ${ruleDoc.ruleName}
-          </a>
-          <br />
       #end
-        </td>
-        <td>
-      #foreach($ruleDoc in $ruleFamily.testRules)
-          <a href="#summaryLink(${ruleFamily.id}, ${ruleDoc.ruleName})"#if($ruleDoc.isDeprecated()) class="deprecated"#end>
-            ${ruleDoc.ruleName}
-          </a>
-          <br />
-      #end
-        </td>
-        <td>
-      #foreach($ruleDoc in $ruleFamily.otherRules1)
-          <a href="#summaryLink(${ruleFamily.id}, ${ruleDoc.ruleName})"#if($ruleDoc.isDeprecated()) class="deprecated"#end>
-            ${ruleDoc.ruleName}
-          </a>
-          <br />
-      #end
-        </td>
-        <td>
-      #foreach($ruleDoc in $ruleFamily.otherRules2)
-          <a href="#summaryLink(${ruleFamily.id}, ${ruleDoc.ruleName})"#if($ruleDoc.isDeprecated()) class="deprecated"#end>
-            ${ruleDoc.ruleName}
-          </a>
-          <br />
-      #end
-        </td>
       </tr>
     #end
   #end