commit 0a89cef0abe9e6cce650a539357061b32beaf099
author michajlo <michajlo@google.com> Mon Apr 06 12:04:12 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Apr 06 12:05:28 2020 -0700
tree 7892286367cbe8aa9569ff464545e607022ea65d
parent 27ec83b0bf4ffdee7a3d630a5322535b5e482596

Ensure attribute name lengths are reasonable

Puts a sensible, but generous, bound on attribute name length in order to
prevent (most probably accidental) runaway name lengths. The expectation is
that no reasonable human is or should be typing out 128 char attribute
names. Instead anything getting to this length is likely machine generated,
and should be checked for accidental unbounded growth.

While this is technically a breaking change, it's expected that the allowance
is generous enough that it's a noop. Do note that the previous max was
MAX_INT or the JVM OOMing, whichever came first, which is something we clearly
shouldn't allow.

RELNOTES: A maximum attribute name length is 128 is enforced
PiperOrigin-RevId: 305086330

src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
index f653a64..fe1e6f6 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
@@ -18,6 +18,7 @@
 import static org.junit.Assert.assertThrows;
 
 import com.google.common.base.Joiner;
+import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Iterables;
@@ -236,6 +237,21 @@
   }
 
   @Test
+  public void testRuleClassTooLongAttributeName() throws Exception {
+    ev.setFailFast(false);
+
+    evalAndExport(
+        "def impl(ctx): return;",
+        "r = rule(impl, attrs = { '" + Strings.repeat("x", 150) + "': attr.int() })");
+
+    assertThat(ev.getEventCollector()).hasSize(1);
+    Event event = ev.getEventCollector().iterator().next();
+    assertThat(event.getKind()).isEqualTo(EventKind.ERROR);
+    assertThat(event.getMessage())
+        .matches("Attribute r\\.x{150}'s name is too long \\(150 > 128\\)");
+  }
+
+  @Test
   public void testDisableDeprecatedParams() throws Exception {
     setSkylarkSemanticsOptions("--incompatible_disable_deprecated_attr_params=true");