| commit | efc3754f8c95e29aac6a7b32f2e19a2210d21607 | [log] [tgz] |
|---|---|---|
| author | Romain Chossart <romainchossart@gmail.com> | Mon Nov 27 01:53:24 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Nov 27 01:54:51 2023 -0800 |
| tree | 4cd8d4b6a7e90118511d138154f7f9000136bc25 | |
| parent | a2207a43391f7deb2fbaecf75fee94b240110952 [diff] |
Return FAILED_PRECONDITION instead of NOT_FOUND when a blob referenced by an action is missing. Fix an issue in the remote execution server used for integration tests where, if a blob is missing from the CAS, it would return NotFound instead of a PreconditionError. See https://github.com/bazelbuild/remote-apis, file build/bazel/remote/execution/v2/remote_execution.proto: // Execute an action remotely. [...] // * `FAILED_PRECONDITION`: One or more errors occurred in setting up the // action requested, such as a missing input or command or no worker being // available. The client may be able to fix the errors and retry. [...] // In the case of a missing input or command, the server SHOULD additionally // send a [PreconditionFailure][google.rpc.PreconditionFailure] error detail // where, for each requested blob not present in the CAS, there is a // `Violation` with a `type` of `MISSING` and a `subject` of // `"blobs/{digest_function/}{hash}/{size}"` indicating the digest of the // missing blob. The `subject` is formatted the same way as the // `resource_name` provided to // [ByteStream.Read][google.bytestream.ByteStream.Read], with the leading // instance name omitted. `digest_function` MUST thus be omitted if its value // is one of MD5, MURMUR3, SHA1, SHA256, SHA384, SHA512, or VSO. In particular, there is no mention of the NOT_FOUND GRPC response code in the Execute documentation. Closes #20295. PiperOrigin-RevId: 585573706 Change-Id: Ib439363d2284523f2cf9f74c353566e98eb6025e
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
