commit 0b6389723a8d9d3a92e49dc0412fb395b62dc32c
author Ulf Adams <ulfjack@google.com> Tue Sep 08 13:25:35 2015 +0000
committer Damien Martin-Guillerez <dmarting@google.com> Tue Sep 08 17:26:18 2015 +0000
tree 2514064f0ee6141d12051a1338a2d560f57e491f
parent 240eb7888627967252229979c3029097f58cbb38

Avoid checking visibility and other constraints for the lipo dependency.

The lipo dependency is artificial; it's an artifact of how LIPO is implemented
in Bazel. Running these checks doesn't make sense; they unnecessarily
disallow perfectly valid scenarios.

--
MOS_MIGRATED_REVID=102550286

src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
index 16982f0..0cfb114 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
@@ -1570,7 +1570,9 @@
       validateDirectPrerequisiteType(prerequisite, attribute);
       validateDirectPrerequisiteFileTypes(prerequisite, attribute);
       validateMandatoryProviders(prerequisite, attribute);
-      prerequisiteValidator.validate(this, prerequisite, attribute);
+      if (attribute.performConstraintsCheck()) {
+        prerequisiteValidator.validate(this, prerequisite, attribute);
+      }
     }
   }