commit 0c100efeba05577b8bc334e1fae31149854bb0b7
author Googler <brandjon@google.com> Mon Sep 30 17:31:27 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Sep 30 17:33:59 2024 -0700
tree 68efd65578e77efb3445e9d68140afb43e219d00
parent cd82f68cfdf44aabaea1931ea9ff870ec7bb4af1

Flip symbolic macro flags

This enables `--experimental_enable_first_class_macros` and `--incompatible_simplify_unconditional_selects_in_rule_attrs` to true. The former releases Symbolic Macros, and with it, Finalizers and Macro-Aware Visibility. The latter is a quality-of-life improvement for macro users that is technically a breaking change: Any rule instantiated with an attribute value of `select({"//conditions:default": foo})` instead sees just `foo`.

Main milestone of #19922.

RELNOTES: Symbolic Macros -- and with them, Finalizers and the new Macro-Aware Visibility model -- are now generally available (`--experimental_enable_first_class_macros` now defaults to true). Trivial `select()` values are automatically unwrapped (`--incompatible_simplify_unconditional_selects_in_rule_attrs` now defaults to true).
PiperOrigin-RevId: 680779247
Change-Id: Icdbf4b47bc893ba61417eddc22c79d85b6f5d920

src/test/java/com/google/devtools/build/lib/starlark/StarlarkOptionsParsingTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/starlark/StarlarkOptionsParsingTest.java b/src/test/java/com/google/devtools/build/lib/starlark/StarlarkOptionsParsingTest.java
index ab12ccd..774452d 100644
--- a/src/test/java/com/google/devtools/build/lib/starlark/StarlarkOptionsParsingTest.java
+++ b/src/test/java/com/google/devtools/build/lib/starlark/StarlarkOptionsParsingTest.java
@@ -660,9 +660,18 @@
     scratch.file(
         "test/pkg/BUILD",
         """
+        # Needed to avoid select() being eliminated as trivial.
+        config_setting(
+            name = "config",
+            values = {"define": "pi=3"},
+        )
+
         alias(
             name = "two",
-            actual = select({"//conditions:default": "//test:three"}),
+            actual = select({
+                ":config": "//test:three",
+                "//conditions:default": "//test:three",
+            }),
         )
         """);