commit 10a6b77e342472e29d168060e06f05a9c7cad66f
author brandjon <brandjon@google.com> Fri Oct 20 20:48:30 2017 +0200
committer Dmitry Lomov <dslomov@google.com> Mon Oct 23 17:16:02 2017 +0200
tree bd718474cb6a0379dc24c71ef0b32acec74a7cc2
parent bc616ec5a44119b8e2b60293947e3aa14fac053f

Be explicit about semantics of Skylark environments

All callers that do not use Environment.Builder#setSemantics should call #useDefaultSemantics. A follow-up CL will enforce this requirement.

Motivation: It's more important that we are strict about semantics than about the other builder args. It's too easy for a mistake in semantics to go unnoticed.

RELNOTES: None
PiperOrigin-RevId: 172912829

src/main/java/com/google/devtools/skylark/Skylark.java

diff --git a/src/main/java/com/google/devtools/skylark/Skylark.java b/src/main/java/com/google/devtools/skylark/Skylark.java
index df7932e..cfa4d6f 100644
--- a/src/main/java/com/google/devtools/skylark/Skylark.java
+++ b/src/main/java/com/google/devtools/skylark/Skylark.java
@@ -56,6 +56,7 @@
   private final Mutability mutability = Mutability.create("interpreter");
   private final Environment env =
       Environment.builder(mutability)
+          .useDefaultSemantics()
           .setGlobals(Environment.DEFAULT_GLOBALS)
           .setEventHandler(PRINT_HANDLER)
           .build();