commit 111845955c1c136729a1c0a2226962309ca45957
author Michajlo Matijkiw <michajlo@google.com> Fri Oct 16 19:00:45 2015 +0000
committer Lukacs Berki <lberki@google.com> Mon Oct 19 08:20:04 2015 +0000
tree aeb0dee75699c1e19b1270c6b8b511cda869bff9
parent e4461a4251131a78d26b5e822e4ba388950c9d48

Brief audit of singleton SkyValues

Minimize indirection wrt singletons, turns out we had one that was completely unused.

--
MOS_MIGRATED_REVID=105621494

src/main/java/com/google/devtools/build/lib/skyframe/ContainingPackageLookupFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ContainingPackageLookupFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/ContainingPackageLookupFunction.java
index 6d6511a..09debbf 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ContainingPackageLookupFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ContainingPackageLookupFunction.java
@@ -41,7 +41,7 @@
 
     PathFragment parentDir = dir.getPackageFragment().getParentDirectory();
     if (parentDir == null) {
-      return ContainingPackageLookupValue.noContainingPackage();
+      return ContainingPackageLookupValue.NONE;
     }
     PackageIdentifier parentId = PackageIdentifier.create(dir.getRepository(), parentDir);
     return env.getValue(ContainingPackageLookupValue.key(parentId));