commit 112840b4d6fafd04e2381a2e52fbad848a818ea6
author Janak Ramakrishnan <janakr@google.com> Thu Dec 29 21:49:56 2016 +0000
committer John Cater <jcater@google.com> Tue Jan 03 15:03:05 2017 +0000
tree f82825c5b02480612178f8238812590925c67909
parent c31f351a191d6927a6483384826297e5549cf426

Remove WalkableGraph#exists and allow WalkableGraph#getValue and WalkableGraph#getException to be given non-existent keys without crashing. Add WalkableGraph#isCycle to fill the gap in testing for the difference between non-existence and depending on a cycle.

--
PiperOrigin-RevId: 143205289
MOS_MIGRATED_REVID=143205289

src/main/java/com/google/devtools/build/lib/skyframe/FilesystemValueChecker.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/FilesystemValueChecker.java b/src/main/java/com/google/devtools/build/lib/skyframe/FilesystemValueChecker.java
index 9a94f3f..6fef55c 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/FilesystemValueChecker.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/FilesystemValueChecker.java
@@ -135,7 +135,7 @@
     @Override
     @Nullable
     public SkyValue get(SkyKey key) throws InterruptedException {
-      return walkableGraph.exists(key) ? walkableGraph.getValue(key) : null;
+      return walkableGraph.getValue(key);
     }
   }