commit | d273cb62f43ef8169415cf60fc96e503ea2ad823 | [log] [tgz] |
---|---|---|
author | Christopher Peterson Sauer <christophersauer@pacbell.net> | Tue May 17 08:20:57 2022 -0700 |
committer | Copybara-Service <copybara-worker@google.com> | Tue May 17 08:22:38 2022 -0700 |
tree | 1dc3253250f3255f07cbb28d464e1399fbcd1903 | |
parent | e575800149c6dc6bd4589d96d8739f18ccdcb2cf [diff] |
Unify URL/URLs parameter code across http_archive, http_file, http_jar Hi wonderful Bazel folks, I--like probably everyone else--make heavy use of the (super handy) http repository rules. While using them, I'd noticed that the docs for the URL attributes they have in common had started drifting. For example, http_file's URLs array doc was mostly same as http_archive's, except that it forgot to specify that the URLs were tried in the order they were specified. jar_file's were much less complete. Similarly, only http_file was missing the URL parameter, which seems a shame, since probably most people only want to supply one authoritative source most of the time. When I looked at the code, it became clear that this was because the implementations were copy-pasted, and being updated separately. So I spent a few minutes cleaning things up and making these commonly used features a little more consistent, fixing the issues above. Hopefully that's welcome. I'd love your thoughtful consideration and review! Thanks, wonderful Bazel folks, for all you do! Cheers, Chris (ex-Googler) P.S. I've given edit access with the "allow edits by maintainers" box. If there are things you'd like changed, feel free also to just make them directly! Closes #15408. PiperOrigin-RevId: 449225740
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md