commit 12291601aeca3b0becb6035a468bee411f075050
author Carmi Grushko <carmi@google.com> Wed Oct 26 19:07:41 2016 +0000
committer Laszlo Csomor <laszlocsomor@google.com> Thu Oct 27 09:27:07 2016 +0000
tree eb875a30aa512e283971d39cf435ac64fb4ff1c1
parent 3bf723e3fb27143c22fe81711c9c9c1fa8c76d30

Improve error message when failing to convert parameter types in Skylark function calls.

--
MOS_MIGRATED_REVID=137303042

src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java b/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java
index a1168b4..4b23350 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java
@@ -438,7 +438,8 @@
         if (!param.isAssignableFrom(value.getClass())) {
           return ArgumentListConversionResult.fromError(
               String.format(
-                  "Cannot convert parameter at position %d to type %s", i, param.toString()));
+                  "Cannot convert parameter at position %d from type %s to type %s",
+                  i, EvalUtils.getDataTypeName(value), param.toString()));
         }
         builder.add(value);
         i++;