| commit | 12ab12e80ad1c9a3510aa4bbfdf3fddafc0bca00 | [log] [tgz] |
|---|---|---|
| author | Jakob Buchgraber <buchgr@google.com> | Wed Jan 23 07:42:30 2019 -0800 |
| committer | Copybara-Service <copybara-piper@google.com> | Wed Jan 23 07:45:15 2019 -0800 |
| tree | 9eb19d51ab9d31c973f979ccc70f1316598718a6 | |
| parent | b5b97e96a13e0d09e0ba2a7b1d7a1a7e18d5892a [diff] |
Revert "Enabling Bazel to generate input symlinks as defined by RE AP?
?I V2."
This reverts commit baa1786.
The symlink resolution in this change is broken, as it does not take into
account parent symlinks. Consider the following structure on the filesystem:
```
a/d/file
a/b/c/symlink -> ../../d/file
```
And action inputs as follows:
```
a/d/file
(f -> a/b/c)/symlink -> ../../d/file
```
with (f -> a/b/c) denoting that f is a symlink to directory c.
This change then builds the following merkle tree:
```
a
d
file
f
symlink -> ../../d/file
```
My guesstimate is that there are a number of additional problems with
this change and we should think hard about them when attempting to
roll foward this change in the future. See for example Bazel's symlink
resolution in FileFunction [1].
A real world example of this error is: #7212
Fixes #7212
[1] https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java;l=114?q=FileFunction
Closes #7216.
PiperOrigin-RevId: 230527829
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.