commit 1434b17ee7843da985d7f1ce61412948143d46e6
author laurentlb <laurentlb@google.com> Mon Aug 27 11:32:34 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Mon Aug 27 11:35:11 2018 -0700
tree ccadf79b21dd03cb0dc19798eb93566b72025c95
parent a6d7dc78891a1bc8d8da19bbd29a5bb320034661

Delete Environment.hasVariable

It's virtually unused, as callers generally want to know what is the value.

https://github.com/bazelbuild/bazel/issues/5637

RELNOTES: None.
PiperOrigin-RevId: 210401091

src/main/java/com/google/devtools/build/lib/syntax/Environment.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Environment.java b/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
index e32b545..888642e 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
@@ -1062,10 +1062,6 @@
     return this;
   }
 
-  public boolean hasVariable(String varname) {
-    return lookup(varname) != null;
-  }
-
   /**
    * Initializes a binding in this Environment. It is an error if the variable is already bound.
    * This is not for end-users, and will throw an AssertionError in case of conflict.
@@ -1074,7 +1070,7 @@
    * @return this Environment, in fluid style
    */
   public Environment setup(String varname, Object value) {
-    if (hasVariable(varname)) {
+    if (lookup(varname) != null) {
       throw new AssertionError(String.format("variable '%s' already bound", varname));
     }
     return setupOverride(varname, value);