Avoid retaining `TypeTable` in non-toplevel `StarlarkFunction`s

Once static type checking and toplevel evaluation of a .bzl file are complete, most of the data in `TypeTable` is no longer needed. Previously, every `StarlarkFunction` retained a reference to its file's `TypeTable`, keeping the entire `TypeTable` alive.

Instead, have `StarlarkFunction` store a shared array of function types for the current module (indexed by function ID) which we extract from the type table. (Strictly speaking, a `StarlarkFunction` needs to know only the type of itself and of the nested functions that it declares; but storing the entire array - as long as the array instance is shared by all functions in the module - results in simpler code, and wastes almost no memory in practice, as measured by benchmarks on large builds.) We still need to store `TypeTable` for `<toplevel>` and `<expr>` `StarlarkFunction`-s, but the toplevel `StarlarkFunction`-s are temporaries, and will get GC-ed after toplevel evaluation.

Also, take the opportunity to lazily initialize `TypeTable.typeConstructors` and `TypeTable.errors`.

Continuing to work towards minimizing the memory impact of enabling static type checking by default.

Working towards #27370

PiperOrigin-RevId: 1006090973
Change-Id: I556e0f600db1a4ac9aaaebae370107beafd83248
8 files changed
tree: edfceb6b9a3dc7df6e91162576e4509524d42094
  1. .bazelci/
  2. .devcontainer/
  3. .gemini/
  4. .github/
  5. docs/
  6. examples/
  7. scripts/
  8. src/
  9. third_party/
  10. tools/
  11. .bazelrc
  12. .bazelversion
  13. .gitattributes
  14. .gitignore
  15. AGENTS.md
  16. AUTHORS
  17. bazel_downloader.cfg
  18. BUILD
  19. CHANGELOG.md
  20. CODE_OF_CONDUCT.md
  21. CODEOWNERS
  22. combine_distfiles.py
  23. combine_distfiles_to_tar.sh
  24. compile.sh
  25. CONTRIBUTING.md
  26. CONTRIBUTORS
  27. distdir.bzl
  28. extensions.bzl
  29. LICENSE
  30. maven_install.json
  31. MODULE.bazel
  32. MODULE.bazel.lock
  33. oneversion_allowlist.csv
  34. oneversion_allowlist_for_tests.csv
  35. pyproject.toml
  36. README.md
  37. repositories.bzl
  38. requirements.txt
  39. SECURITY.md
  40. verify_module_bazel_lock.sh
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Reporting a Vulnerability

To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.

Contributing to Bazel

See CONTRIBUTING.md

Build status