commit 17d975ee226c59c164ecdab9c897a35d9604e192
author laurentlb <laurentlb@google.com> Fri Sep 01 17:49:23 2017 +0200
committer Vladimir Moskva <vladmos@google.com> Fri Sep 01 20:08:25 2017 +0200
tree 16bd9374019b499a441847c8137f7448e94376f2
parent 9bd280ba663557a44c0177327cf668ff813a397d

Remove the Dialect type from the Parser.

Let's use the same parser. Dialect differences are checked in a separate
validation pass.

RELNOTES: None.
PiperOrigin-RevId: 167280201

src/main/java/com/google/devtools/build/lib/syntax/Parser.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Parser.java b/src/main/java/com/google/devtools/build/lib/syntax/Parser.java
index e948b84..6edf737 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/Parser.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/Parser.java
@@ -201,20 +201,14 @@
    *
    * @param input the input to parse
    * @param eventHandler a reporter for parsing errors
-   * @param dialect may restrict the parser to Build-language features
    * @see BuildFileAST#parseBuildString
    * @see BuildFileAST#parseSkylarkString
    */
-  public static ParseResult parseFile(
-      ParserInputSource input, EventHandler eventHandler, Dialect dialect) {
+  public static ParseResult parseFile(ParserInputSource input, EventHandler eventHandler) {
     Lexer lexer = new Lexer(input, eventHandler);
     Parser parser = new Parser(lexer, eventHandler);
     List<Statement> statements = parser.parseFileInput();
     boolean errors = parser.errorsCount > 0 || lexer.containsErrors();
-    // TODO(laurentlb): Remove dialect argument.
-    if (dialect == Dialect.BUILD) {
-      errors |= !ValidationEnvironment.checkBuildSyntax(statements, eventHandler);
-    }
     return new ParseResult(
         statements, parser.comments, locationFromStatements(lexer, statements), errors);
   }