| commit | 365f67ee4fe24a8751adb98067b063f9c0168f82 | [log] [tgz] |
|---|---|---|
| author | brandjon <brandjon@google.com> | Thu Oct 08 19:18:11 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Oct 08 19:19:18 2020 -0700 |
| tree | 159b3cffb6707d213f34fe95f978503985c2788e | |
| parent | d9b55f822ce760840144b08ed508b27b82bedaad [diff] |
Don't prematurely add native module to bzl env Previously, ConfiguredRuleClassProvider#getEnvironment returned an env that contained a binding for "native", mapping to a StarlarkNativeModule instance. This got overwritten in PackageFactory to instead map to a struct containing the same fields (e.g. glob()) plus all the registered rules (e.g. cc_library). Since ASTFileLookupFunction used the getEnvironment() method, it relied on the bogus StarlarkNativeModule object being there for static name validation to work. As of unknown commit, ASTFileLookupFunction now queries PackageFactory for the final environment, so we are free to no longer add this incomplete dummy object. Except for BzlEnv, StarlarkNativeModule is now only used in conjunction with Starlark.addMethods(), not Starlark.addModule(), so the object itself is almost inaccessible. (Its class is still the home of the user documentation for the special native object fields.) Verified that ApiExporter produces the same result after this change. (In fact, that target doesn't even depend on this CL.) Cleanup along the way to #11437 and #11954. RELNOTES: None PiperOrigin-RevId: 336211639
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
