commit 19a3f559b8bfe878a5f7c72969911107b96d21c4
author Googler <noreply@google.com> Tue Sep 03 08:22:16 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Sep 03 08:23:12 2019 -0700
tree e188fdaa57b5a1a3821c742eef375aaf8048f5e7
parent 06fcb83c550606cc2bf331006d4e276e490724ed

Compute root relative path on the fly to reduce memory in DerivedArtifact objects

This especially helps ThinLTO builds, which have many more artifacts.

RELNOTES: None.
PiperOrigin-RevId: 266932890

src/test/java/com/google/devtools/build/lib/actions/ArtifactTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/actions/ArtifactTest.java b/src/test/java/com/google/devtools/build/lib/actions/ArtifactTest.java
index ef9cd43b..86111df 100644
--- a/src/test/java/com/google/devtools/build/lib/actions/ArtifactTest.java
+++ b/src/test/java/com/google/devtools/build/lib/actions/ArtifactTest.java
@@ -68,7 +68,8 @@
         IllegalArgumentException.class,
         () ->
             ActionsTestUtil.createArtifactWithExecPath(
-                ArtifactRoot.asDerivedRoot(execDir, bogusDir), f1.relativeTo(execDir)));
+                    ArtifactRoot.asDerivedRoot(execDir, bogusDir), f1.relativeTo(execDir))
+                .getRootRelativePath());
   }
 
   private static long getUsedMemory() {
@@ -328,7 +329,9 @@
         IllegalArgumentException.class,
         () ->
             ActionsTestUtil.createArtifactWithExecPath(
-                ArtifactRoot.asDerivedRoot(execRoot, scratch.dir("/a")), PathFragment.create("c")));
+                    ArtifactRoot.asDerivedRoot(execRoot, scratch.dir("/a")),
+                    PathFragment.create("c"))
+                .getRootRelativePath());
   }
 
   @Test