commit 19d692c57781a9848b1297835d095a7ab5c04e68
author mstaib <mstaib@google.com> Wed Aug 29 11:44:15 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Wed Aug 29 11:45:54 2018 -0700
tree d3af7185dc00c15b7a1040c56555c0c1859e0958
parent 2cb8ac1b76e420b5811a6ef3e4370fc3e09dcc5b

Avoid re-clearing the analysis cache (and saying so) after cleans.

1) After cleaning, don't bother checking the configurations - because the old ones were lost in the Skyframe graph being cleared, the ones we have now are definitely different (if possibly equivalent) instances, but we don't care because the graph is empty already, so there's nothing to clean up.
2) After cleaning, the fact that the last completed build was discard_analysis_cache is no longer relevant. The graph was completely cleared already, so there's again nothing to clean up.
3) When the last completed build was discard_analysis_cache, it doesn't matter what configuration we have, so there's no point in doing a potentially lengthy diff whose result we don't care about.
4) When the last completed build was discard_analysis_cache, we do throw away the analysis cache at the start of the next one. But not because the build options have changed. Print a different message in that case.

This is largely a cosmetic change - the graph was already empty, so clearing it should have been pretty trivial. But the message being printed is misleading.

RELNOTES: None.
PiperOrigin-RevId: 210760599