commit 1a47d9949d6d3d0fbd35708c6950508c2940b797
author leba <leba@google.com> Tue Apr 19 01:35:26 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Apr 19 01:36:27 2022 -0700
tree a9a7c594cf9f553b9c54bbae069a64af3c335d9a
parent 6e9239ed904e01ea270f3c7d2e05c5f0be0ee341

Use ImmutableSet instead of ImmutableList for (Skyframe)AnalysisResult.

Also made some private methods in SkyframeBuildView explicitly return Immutable collections instead of a general one.

PiperOrigin-RevId: 442744276

src/main/java/com/google/devtools/build/lib/analysis/AnalysisResult.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisResult.java b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisResult.java
index dae3d10..2c5c153 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisResult.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisResult.java
@@ -14,7 +14,6 @@
 
 package com.google.devtools.build.lib.analysis;
 
-import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.ImmutableSortedSet;
@@ -32,7 +31,7 @@
 public class AnalysisResult {
   private final BuildConfigurationCollection configurations;
   private final ImmutableSet<ConfiguredTarget> targetsToBuild;
-  @Nullable private final ImmutableList<ConfiguredTarget> targetsToTest;
+  @Nullable private final ImmutableSet<ConfiguredTarget> targetsToTest;
   private final ImmutableSet<ConfiguredTarget> targetsToSkip;
   @Nullable private final FailureDetail failureDetail;
   private final ActionGraph actionGraph;
@@ -50,7 +49,7 @@
       BuildConfigurationCollection configurations,
       ImmutableSet<ConfiguredTarget> targetsToBuild,
       ImmutableMap<AspectKey, ConfiguredAspect> aspects,
-      @Nullable ImmutableList<ConfiguredTarget> targetsToTest,
+      @Nullable ImmutableSet<ConfiguredTarget> targetsToTest,
       ImmutableSet<ConfiguredTarget> targetsToSkip,
       @Nullable FailureDetail failureDetail,
       ActionGraph actionGraph,
@@ -105,7 +104,7 @@
    * (e.g. "build" command rather than "test" command).
    */
   @Nullable
-  public ImmutableList<ConfiguredTarget> getTargetsToTest() {
+  public ImmutableSet<ConfiguredTarget> getTargetsToTest() {
     return targetsToTest;
   }