commit 1fccb31837f344e05b4e291d117e2b7e26eddc76
author Andrew Johnson <ajohnson@stripe.com> Mon Dec 05 18:27:27 2016 +0000
committer Damien Martin-Guillerez <dmarting@google.com> Tue Dec 06 12:04:37 2016 +0000
tree 60ce2b10d2f72e8c9301eda3c93a653c3341cf50
parent 161c4a34c893bf8e25af00c18e95576bc2f82b5a

Add quotes around variables when running dirname

If a user happens to have spaces in the path name,
`scripts/bootstrap/buildenv.sh` will fail with the error `usage: dirname
path`. Quoting the argument to `dirname` when setting `WORKSPACE_DIR`
avoids this issue.

Closes #2030.

--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2030
PiperOrigin-RevId: 141067912
MOS_MIGRATED_REVID=141067912

scripts/bootstrap/buildenv.sh

diff --git a/scripts/bootstrap/buildenv.sh b/scripts/bootstrap/buildenv.sh
index 8345dc3..dbd7d24 100755
--- a/scripts/bootstrap/buildenv.sh
+++ b/scripts/bootstrap/buildenv.sh
@@ -32,7 +32,7 @@
 
 # Set standard variables
 DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
-WORKSPACE_DIR="$(dirname $(dirname ${DIR}))"
+WORKSPACE_DIR="$(dirname "$(dirname "${DIR}")")"
 
 JAVA_VERSION=${JAVA_VERSION:-1.8}
 BAZELRC=${BAZELRC:-"/dev/null"}