commit 1fec40d89c3a3af2ce602d734f19700a4a6121e3
author Janak Ramakrishnan <janakr@google.com> Mon Mar 21 19:32:17 2016 +0000
committer Lukacs Berki <lberki@google.com> Tue Mar 22 08:09:07 2016 +0000
tree d1f6e92f4cc7501cdbdec6f0cdf3f4952095d798
parent 50959b2552a7aea11f4ae2be5c33087230c11b37

Transform the getBatch result in SkyFunctionEnvironment instead of copying it. The copying showed up as a source of memory spikiness.

--
MOS_MIGRATED_REVID=117741939

src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java b/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
index 7413a1b..3b93434 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
@@ -229,6 +229,12 @@
       return ((ValueWithMetadata) value).getErrorInfo();
     }
     return null;
+  }
 
+  static NestedSet<TaggedEvents> getEvents(SkyValue value) {
+    if (value instanceof ValueWithMetadata) {
+      return ((ValueWithMetadata) value).getTransitiveEvents();
+    }
+    return NestedSetBuilder.emptySet(Order.STABLE_ORDER);
   }
 }