commit 202c5b39007d32cb2da5086aface684b7d769ad8
author dslomov <dslomov@google.com> Wed May 03 12:06:58 2017 +0200
committer Damien Martin-Guillerez <dmarting@google.com> Wed May 03 17:26:03 2017 +0200
tree 857ad432ffcfdaf94d3b0686d5b0b6086f1fa4a1
parent fd6c97061906a38a1b4b3500d0cf3829e4d45725

Remove memory regression introduced with OutputGroupInfo provider.

Almost every target has an OutputGroupProvider. Do not create another
Key->Provider map just for it.

RELNOTES: None.
PiperOrigin-RevId: 154937690

src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java b/src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java
index acaa4a8..cb7daee 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java
@@ -186,6 +186,9 @@
     if (providerKey.equals(DefaultProvider.SKYLARK_CONSTRUCTOR.getKey())) {
       return getDefaultProvider();
     }
+    if (providerKey.equals(OutputGroupProvider.SKYLARK_CONSTRUCTOR.getKey())) {
+      return OutputGroupProvider.get(this);
+    }
     SkylarkProviders skylarkProviders = getProvider(SkylarkProviders.class);
     if (skylarkProviders != null) {
       return skylarkProviders.getDeclaredProvider(providerKey);

src/main/java/com/google/devtools/build/lib/analysis/MergedConfiguredTarget.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/MergedConfiguredTarget.java b/src/main/java/com/google/devtools/build/lib/analysis/MergedConfiguredTarget.java
index 2c0fcfb..bff4b1c 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/MergedConfiguredTarget.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/MergedConfiguredTarget.java
@@ -112,6 +112,9 @@
         getAllProviders(base, aspects, ExtraActionArtifactsProvider.class));
 
     TransitiveInfoProviderMap.Builder aspectProviders = TransitiveInfoProviderMap.builder();
+    if (mergedOutputGroupProvider != null) {
+      aspectProviders.add(mergedOutputGroupProvider);
+    }
     if (mergedSkylarkProviders != null) {
       aspectProviders.add(mergedSkylarkProviders);
     }
@@ -123,7 +126,8 @@
       for (Map.Entry<Class<? extends TransitiveInfoProvider>, TransitiveInfoProvider> entry :
           aspect.getProviders().entrySet()) {
         Class<? extends TransitiveInfoProvider> providerClass = entry.getKey();
-        if (SkylarkProviders.class.equals(providerClass)
+        if (OutputGroupProvider.class.equals(providerClass)
+            || SkylarkProviders.class.equals(providerClass)
             || ExtraActionArtifactsProvider.class.equals(providerClass)) {
           continue;
         }

src/main/java/com/google/devtools/build/lib/analysis/OutputGroupProvider.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/OutputGroupProvider.java b/src/main/java/com/google/devtools/build/lib/analysis/OutputGroupProvider.java
index 397d7fd..0606a1f 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/OutputGroupProvider.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/OutputGroupProvider.java
@@ -58,7 +58,7 @@
  */
 @Immutable
 public final class OutputGroupProvider extends SkylarkClassObject
-    implements SkylarkIndexable, Iterable<String> {
+    implements TransitiveInfoProvider, SkylarkIndexable, Iterable<String> {
   public static final String SKYLARK_NAME = "output_groups";
 
   public static NativeClassObjectConstructor SKYLARK_CONSTRUCTOR = new Constructor();
@@ -127,7 +127,7 @@
 
   @Nullable
   public static OutputGroupProvider get(TransitiveInfoCollection collection) {
-    return (OutputGroupProvider) collection.get(SKYLARK_CONSTRUCTOR.getKey());
+    return (OutputGroupProvider) collection.getProvider(OutputGroupProvider.class);
   }
 
   @Nullable

src/main/java/com/google/devtools/build/lib/analysis/RuleConfiguredTargetBuilder.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/RuleConfiguredTargetBuilder.java b/src/main/java/com/google/devtools/build/lib/analysis/RuleConfiguredTargetBuilder.java
index bdf8e10..16baad7 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/RuleConfiguredTargetBuilder.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/RuleConfiguredTargetBuilder.java
@@ -131,7 +131,7 @@
       }
 
       OutputGroupProvider outputGroupProvider = new OutputGroupProvider(outputGroups.build());
-      addNativeDeclaredProvider(outputGroupProvider);
+      addProvider(OutputGroupProvider.class, outputGroupProvider);
       addSkylarkTransitiveInfo(OutputGroupProvider.SKYLARK_NAME, outputGroupProvider);
     }
 

src/main/java/com/google/devtools/build/lib/analysis/SkylarkProviders.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/SkylarkProviders.java b/src/main/java/com/google/devtools/build/lib/analysis/SkylarkProviders.java
index 0778ade..99a4534 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/SkylarkProviders.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/SkylarkProviders.java
@@ -164,7 +164,10 @@
           throw new DuplicateException("Provider " + key + " provided twice");
         }
 
-        resultBuilder.put(key, map.get(key));
+        V v = map.get(key);
+        if (v != null) {
+          resultBuilder.put(key, v);
+        }
       }
     }
     return resultBuilder.build();