| commit | 21b759ddf52f6f752637420e710b64eb070c1e1c | [log] [tgz] |
|---|---|---|
| author | Googler <noreply@google.com> | Wed Apr 03 10:57:09 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Apr 03 10:58:58 2019 -0700 |
| tree | 6b5947fca65b0d9cc757b57ee84de1f463cce545 | |
| parent | b3b3e8bb7320ef76dfec97f66284e0a9f7eda2d2 [diff] |
Fix setting default values for Pattern options Options in bazel can have default values assigned to them, which are validated against allowed values. We have a bug where restricting the possible values of a Pattern will break the default value. It happens because we create Pattern objects, which use the default (by reference) implementation of equals. This violates the contract used by bazel converters that options created from the same representation will return true if compared using corresponding equals method. Create a wrapper around Pattern which implements proper equals (compliant with the contract). Also, specify the contract in Converter to explicitly state the assumptions and add tests covering the RegexPatternConverter and the problematic scenario from the bug. RELNOTES: none. PiperOrigin-RevId: 241764234
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.