commit 231d77d869f90de5eb40b8630603a8cc7cd40121
author lberki <lberki@google.com> Thu Jan 03 11:18:11 2019 -0800
committer Copybara-Service <copybara-piper@google.com> Thu Jan 03 11:20:00 2019 -0800
tree 57c1dc8dda40fd871dcc9ae9c62d42a7f0872035
parent 5983067f869ea4c9ce114a57030028d3533623fc

Refactor DependencyResolver a bit.

RELNOTES: None.
PiperOrigin-RevId: 227718701

src/main/java/com/google/devtools/build/lib/packages/TargetUtils.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/TargetUtils.java b/src/main/java/com/google/devtools/build/lib/packages/TargetUtils.java
index b68f907..1f947e6 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/TargetUtils.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/TargetUtils.java
@@ -80,8 +80,7 @@
    * Returns true iff {@code target} is a {@code test_suite} rule.
    */
   public static boolean isTestSuiteRule(Target target) {
-    return target instanceof Rule &&
-        isTestSuiteRuleName(((Rule) target).getRuleClass());
+    return target instanceof Rule && isTestSuiteRuleName(((Rule) target).getRuleClass());
   }
 
   /**
@@ -129,8 +128,7 @@
    * Wraps the above calls into one generic check safely applicable to any rule.
    */
   public static boolean isTestRuleAndRunsLocally(Rule rule) {
-    return isTestOrTestSuiteRule(rule) &&
-        (isLocalTestRule(rule) || isExclusiveTestRule(rule));
+    return isTestOrTestSuiteRule(rule) && (isLocalTestRule(rule) || isExclusiveTestRule(rule));
   }
 
   /**
@@ -270,7 +268,7 @@
     return index != -1 ? ruleClass.substring(0, index) : ruleClass;
   }
 
-  private static boolean isExplicitDependency(Rule rule, Label label) throws InterruptedException {
+  private static boolean isExplicitDependency(Rule rule, Label label) {
     if (rule.getVisibility().getDependencyLabels().contains(label)) {
       return true;
     }
@@ -322,7 +320,7 @@
    * Target} target did not exist, due to {@link NoSuchThingException} e.
    */
   public static String formatMissingEdge(
-      @Nullable Target target, Label label, NoSuchThingException e) throws InterruptedException {
+      @Nullable Target target, Label label, NoSuchThingException e) {
     // instanceof returns false if target is null (which is exploited here)
     if (target instanceof Rule) {
       Rule rule = (Rule) target;