Report errors for all files with Error Prone diagnostics, not just the first one

This removes logic that was skipping Error Prone of compilations with errors. The intent was to skip analyzing compilations with javac errors, but it also meant that if Error Prone reported an error analyzing a file all subsequent files were skipped.

As of unknown commit, `ErrorProneAnalyzer` handles skipping analysis of compilations with errors (and distinguishing between javac and Error Prone errors), so it's safe for JavaBuilder to unconditionally run ErrorProne and let it decided whether or not to proceed.

This change also removes some bookkeeping about the number of 'flow' events javac processes and skips, which was used for testing. Since it no longer skips flow events, there isn't a good way to perform the assertion that was done previously. Since that logic was added we have better end to end integration tests for the Error Prone JavaBuilder integration, which reduces the risk of accidentally turning Error Prone off.

PiperOrigin-RevId: 641283846
Change-Id: I539f0713879835f031cb13a015b45dfa90e20c24
4 files changed
tree: f65da966db1bafedc58c2c9e379f48a6f5deba7c
  1. .bazelci/
  2. .github/
  3. examples/
  4. scripts/
  5. site/
  6. src/
  7. third_party/
  8. tools/
  9. .bazelrc
  10. .bazelversion
  11. .gitattributes
  12. .gitignore
  13. AUTHORS
  14. bazel_downloader.cfg
  15. BUILD
  16. CHANGELOG.md
  17. CODE_OF_CONDUCT.md
  18. CODEOWNERS
  19. combine_distfiles.py
  20. combine_distfiles_to_tar.sh
  21. compile.sh
  22. CONTRIBUTING.md
  23. CONTRIBUTORS
  24. distdir.bzl
  25. extensions.bzl
  26. LICENSE
  27. maven_install.json
  28. MODULE.bazel
  29. MODULE.bazel.lock
  30. rbe_extension.bzl
  31. README.md
  32. repositories.bzl
  33. requirements.txt
  34. SECURITY.md
  35. WORKSPACE.bzlmod
  36. workspace_deps.bzl
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Reporting a Vulnerability

To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.

Contributing to Bazel

See CONTRIBUTING.md

Build status