Skylark: allow_files can now accept a string list argument
--
MOS_MIGRATED_REVID=122052644
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
index 50bd25a..7d8a64a 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
@@ -161,8 +161,16 @@
@Test
public void testAttrAllowedFileTypesWrongType() throws Exception {
checkErrorContains(
- "allow_files should be a boolean or a filetype object.",
- "attr.label_list(allow_files = ['.xml'])");
+ "allow_files should be a boolean or a string list",
+ "attr.label_list(allow_files = 18)");
+ }
+
+ @Test
+ public void testAttrWithList() throws Exception {
+ Attribute attr = evalAttributeDefinition("attr.label_list(allow_files = ['.xml'])")
+ .build("a1");
+ assertTrue(attr.getAllowedFileTypesPredicate().apply("a.xml"));
+ assertFalse(attr.getAllowedFileTypesPredicate().apply("a.txt"));
}
@Test
