commit | c046f9675d188fcd856119e8f1e9e035727659b1 | [log] [tgz] |
---|---|---|
author | plf <plf@google.com> | Tue Feb 22 06:17:05 2022 -0800 |
committer | Copybara-Service <copybara-worker@google.com> | Tue Feb 22 06:18:39 2022 -0800 |
tree | 6150dbe1057cc94b5b9b2e57074360136d47447f | |
parent | 8bd989ed5fb0488922a9536233d167c3e37b765f [diff] |
Fix linker inputs for cc_shared_library linking This CL makes cc_shared_library and cc_binary account for the possibility that a single rule (i.e. a single owner) may place more than one linker_input in a linking context. There is no rule saying that this cannot be the case but until now the implementation of cc_library did place just a single linker input per owner. The Starlark implementation of cc_library is slightly different and has made this bug surface. Rather than change Starlark cc_library we fix cc_shared_library to have the right behavior. We won't control every C++ rule people will write using the Starlark API and therefore can't guarantee that some other rule won't place more than one linker_input per owner. The existing tests already broke with the Starlark cc_library implementation. RELNOTES:none PiperOrigin-RevId: 430195224
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md