commit 2571a95a6835aeb14386ec236f4c98f46bcb44fa
author John Cater <jcater@google.com> Tue Mar 23 13:26:32 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 23 13:27:56 2021 -0700
tree 282be259476c1c0ce2801fdc364188d800b1cb0a
parent 5593358a58b66f06c4e421bb48856de94c3fd625

Remove makeLabel helper function and call Label.parseAbsoluteUnchecked

I'm breaking up https://github.com/bazelbuild/bazel/pull/13246 into smaller changes: this one is a pure inlining.

Closes #13256.

PiperOrigin-RevId: 364630488

src/test/java/com/google/devtools/build/lib/skyframe/ConstraintValueLookupUtilTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/ConstraintValueLookupUtilTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/ConstraintValueLookupUtilTest.java
index 68dbf72..a779658 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/ConstraintValueLookupUtilTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/ConstraintValueLookupUtilTest.java
@@ -23,6 +23,7 @@
 import com.google.devtools.build.lib.analysis.BlazeDirectories;
 import com.google.devtools.build.lib.analysis.platform.ConstraintValueInfo;
 import com.google.devtools.build.lib.analysis.util.AnalysisMock;
+import com.google.devtools.build.lib.cmdline.Label;
 import com.google.devtools.build.lib.rules.platform.ToolchainTestCase;
 import com.google.devtools.build.lib.skyframe.ConstraintValueLookupUtil.InvalidConstraintValueException;
 import com.google.devtools.build.lib.skyframe.util.SkyframeExecutorTestUtils;
@@ -70,12 +71,12 @@
   public void testConstraintValueLookup() throws Exception {
     ConfiguredTargetKey linuxKey =
         ConfiguredTargetKey.builder()
-            .setLabel(makeLabel("//constraints:linux"))
+            .setLabel(Label.parseAbsoluteUnchecked("//constraints:linux"))
             .setConfigurationKey(targetConfigKey)
             .build();
     ConfiguredTargetKey macKey =
         ConfiguredTargetKey.builder()
-            .setLabel(makeLabel("//constraints:mac"))
+            .setLabel(Label.parseAbsoluteUnchecked("//constraints:mac"))
             .setConfigurationKey(targetConfigKey)
             .build();
     GetConstraintValueInfoKey key =
@@ -98,7 +99,7 @@
 
     ConfiguredTargetKey targetKey =
         ConfiguredTargetKey.builder()
-            .setLabel(makeLabel("//invalid:not_a_constraint"))
+            .setLabel(Label.parseAbsoluteUnchecked("//invalid:not_a_constraint"))
             .setConfigurationKey(targetConfigKey)
             .build();
     GetConstraintValueInfoKey key = GetConstraintValueInfoKey.create(ImmutableList.of(targetKey));
@@ -121,7 +122,7 @@
   public void testConstraintValueLookup_targetDoesNotExist() throws Exception {
     ConfiguredTargetKey targetKey =
         ConfiguredTargetKey.builder()
-            .setLabel(makeLabel("//fake:missing"))
+            .setLabel(Label.parseAbsoluteUnchecked("//fake:missing"))
             .setConfigurationKey(targetConfigKey)
             .build();
     GetConstraintValueInfoKey key = GetConstraintValueInfoKey.create(ImmutableList.of(targetKey));