commit 25ef675442dd22ce170a6d03b51de927ee041db4
author cushon <cushon@google.com> Tue Feb 25 11:02:33 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Feb 25 11:03:47 2020 -0800
tree 7d35a08e9fe78e02895057f3bc278c0ee1465d96
parent 5505cc554660d5f02fd56cb2064b07a5922dc032

Make --verbose_failures imply --materialize_param_files

the verbose failure message may include command lines with param
files.

PiperOrigin-RevId: 297156180

src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java

diff --git a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java b/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
index 5d804f8..b05674f 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
@@ -127,7 +127,7 @@
       help =
           "Writes intermediate parameter files to output tree even when using "
               + "remote action execution. Useful when debugging actions. "
-              + "This is implied by --subcommands.")
+              + "This is implied by --subcommands and --verbose_failures.")
   public boolean materializeParamFiles;
 
   @Option(
@@ -139,8 +139,10 @@
   public boolean materializeParamFilesDirectly;
 
   public boolean shouldMaterializeParamFiles() {
-    // Implied by --subcommands
-    return materializeParamFiles || showSubcommands != ActionExecutionContext.ShowSubcommands.FALSE;
+    // Implied by --subcommands and --verbose_failures
+    return materializeParamFiles
+        || showSubcommands != ActionExecutionContext.ShowSubcommands.FALSE
+        || verboseFailures;
   }
 
   @Option(