Remove shortcut addProvider() methods, to prepare for AutoValue-ed providers.

Such providers have a create() method which returns an object whose runtime class differs from its compile-time class, which makes the shortcut methods behave unexpectedly.

--
MOS_MIGRATED_REVID=109815042
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java b/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java
index f7f40c6..d4f2801 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java
@@ -237,6 +237,7 @@
         Object lateBoundPrereq = ruleContext.getPrerequisite(":late", TARGET);
         return new ConfiguredAspect.Builder("testaspect", ruleContext)
             .addProvider(
+                AspectInfo.class,
                 new AspectInfo(
                     NestedSetBuilder.create(
                         Order.STABLE_ORDER, lateBoundPrereq != null ? "non-empty" : "empty")))