| commit | 280ef6915b0f507218a073974825d6aa7effddee | [log] [tgz] |
|---|---|---|
| author | chiwang <chiwang@google.com> | Mon May 09 08:20:19 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon May 09 08:21:45 2022 -0700 |
| tree | 7260f80c142b9cb237636a47a7ce66ce3504a2c3 | |
| parent | 74fff5526600e8f8927ac6dda51191feeedee041 [diff] |
Remote: Prefetch input files into a temporary path first. When building with build without bytes and dynamic execution, we need prefetch input files for local actions. Sometimes, multiple local actions could share the same input files, so there could be a case where multiple call sites share the same download instance. If the local action is cancelled (due to remote branch wins), the download it requested should also be cancelled only if that download is not shared with other local action (or all the releated local actions are cancelled). Before this change, the inputs are written to their final destination directly. This is fine if we can make sure no race or bug in the prefetcher. However, this is not true: https://github.com/bazelbuild/bazel/issues/15010. The root cause is, when cancelling the downloads, sometimes, the partially downloaded files on the disk are not deleted. By making the prefetcher download input to a temporary path first, we can: 1. Mitigate the race: only the final move step will potentially cause the race condition. 2. Provide a way to observe the race: if these is no race, all temporary files should be either moved or deleted. But when running with this change, many temporary files exist. Working towards https://github.com/bazelbuild/bazel/issues/12454. PiperOrigin-RevId: 447473693
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
