commit 2852b361c026c029ea3eca9c83e5e04f76a10f48
author laurentlb <laurentlb@google.com> Tue Nov 06 11:36:45 2018 -0800
committer Copybara-Service <copybara-piper@google.com> Tue Nov 06 11:38:44 2018 -0800
tree c13f24c3ac5bcd39b21f9903ae532408cc4864d4
parent ee28af4f86783fa84cc1c0d96ca0eca9bb7bf1d0

Parser: fix the location of ArgumentException

We now show the location of the exact argument, instead of pointing at the end of the function call.

RELNOTES: None.
PiperOrigin-RevId: 220320701

src/main/java/com/google/devtools/build/lib/syntax/Parser.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Parser.java b/src/main/java/com/google/devtools/build/lib/syntax/Parser.java
index 3e9ebd5..dd79d66 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/Parser.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/Parser.java
@@ -539,7 +539,7 @@
     try {
       Argument.validateFuncallArguments(arguments);
     } catch (Argument.ArgumentException e) {
-      reportError(lexer.createLocation(token.left, token.right), e.getMessage());
+      reportError(e.getLocation(), e.getMessage());
     }
     return arguments;
   }