starlark: remove Dict.of(K, V) constructors

They are mostly used in tests, and aren't necessary even there.

PiperOrigin-RevId: 340666283

src/main/java/com/google/devtools/build/lib/packages/StructProvider.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/StructProvider.java b/src/main/java/com/google/devtools/build/lib/packages/StructProvider.java
index 2a1fd88..dcdd3a5 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/StructProvider.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/StructProvider.java
@@ -43,19 +43,14 @@
     return create(kwargs, thread.getCallerLocation());
   }
 
-  // Called from StarlarkRepositoryContext. TODO(adonovan): eliminate.
-  public StructImpl createWithBuiltinLocation(Dict<String, Object> kwargs) throws EvalException {
-    return create(kwargs, Location.BUILTIN);
-  }
-
-  private StructImpl create(Dict<String, Object> kwargs, Location location) throws EvalException {
-    if (kwargs.containsKey("to_json")) {
+  public StructImpl create(Map<String, Object> fields, Location location) throws EvalException {
+    if (fields.containsKey("to_json")) {
       throw Starlark.errorf("cannot override built-in struct function 'to_json'");
     }
-    if (kwargs.containsKey("to_proto")) {
+    if (fields.containsKey("to_proto")) {
       throw Starlark.errorf("cannot override built-in struct function 'to_proto'");
     }
-    return StarlarkInfo.create(this, kwargs, location);
+    return StarlarkInfo.create(this, fields, location);
   }
 
   /**
@@ -65,7 +60,7 @@
    * providers, such as the {@code native} object, and the struct fields of {@code ctx} like {@code
    * ctx.attr}.
    */
-  public StarlarkInfo create(Map<String, Object> values, String errorMessageFormatForUnknownField) {
-    return StarlarkInfo.createWithCustomMessage(this, values, errorMessageFormatForUnknownField);
+  public StarlarkInfo create(Map<String, Object> fields, String errorMessageFormatForUnknownField) {
+    return StarlarkInfo.createWithCustomMessage(this, fields, errorMessageFormatForUnknownField);
   }
 }