commit 2ae3eaea447820c5fd33f3b3eeb1cb0f9df4768c
author tomlu <tomlu@google.com> Mon Aug 28 19:33:17 2017 +0200
committer Vladimir Moskva <vladmos@google.com> Tue Aug 29 13:31:24 2017 +0200
tree 800ca148c0f0ef45b591ee2bf0157a6d81f2c56c
parent 6ccff29c57c9795d93eec496fdc7cfc3c135d58a

Remove TODO from LegacyCompilationSupport.

PiperOrigin-RevId: 166722992

src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java

diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java b/src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java
index e65b559..4350701 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java
@@ -598,10 +598,8 @@
           ? StrippingType.DYNAMIC_LIB
           : StrippingType.DEFAULT;
     } catch (CommandLineExpansionException e) {
-      // TODO(b/64941219): This code should be rewritten to not expand the command line
-      // in the analysis phase
       // This can't actually happen, because the command lines used by this class do
-      // not throw.
+      // not throw. This class is slated for deletion, so throwing an assertion is good enough.
       throw new AssertionError("Cannot fail to expand command line but did.", e);
     }
   }