commit 2b8a3a45b22fd544230434f3e4ffd6f15334adc8
author Janak Ramakrishnan <janakr@google.com> Fri Oct 14 11:41:27 2016 +0000
committer Yun Peng <pcloudy@google.com> Fri Oct 14 20:24:00 2016 +0000
tree 50fdcdbb93065fcd407b321902b5c5840cf6d7ee
parent 01906edb8873e9d8127f17fee8fba294122da287

Stop storing a set in GroupedListHelper to deduplicate SkyKey dep requests. Instead, deduplicate when the helper is actually added to a GroupedList.

--
MOS_MIGRATED_REVID=136145321

src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
index 82d6922..4c8ebce 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
@@ -473,9 +473,9 @@
   }
 
   @Override
-  public synchronized void addTemporaryDirectDeps(GroupedListHelper<SkyKey> helper) {
+  public synchronized Set<SkyKey> addTemporaryDirectDeps(GroupedListHelper<SkyKey> helper) {
     Preconditions.checkState(!isDone(), "add temp shouldn't be done: %s %s", helper, this);
-    getTemporaryDirectDeps().append(helper);
+    return getTemporaryDirectDeps().append(helper);
   }
 
   @Override