commit 2c0deceb5a94e8c3cb84b0f988ba5ceedda124af
author John Cater <jcater@google.com> Tue Apr 02 09:18:18 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Apr 02 09:20:19 2019 -0700
tree 693c51c492055f9359dbf2d5b2f8e8c9fd682098
parent 800b1034c5e0e00e4a5c1c280a25f7ae349b7c4f

Rename RuleTransitionData to AttributeTransitionData.

Rule transitions will use a different data holder.

part of work on #7814.

Closes #7918.

PiperOrigin-RevId: 241541559

src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java b/src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java
index 41d6ce0..1e179b2 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java
@@ -32,9 +32,9 @@
 import com.google.devtools.build.lib.events.Event;
 import com.google.devtools.build.lib.events.Location;
 import com.google.devtools.build.lib.packages.Attribute.LabelLateBoundDefault;
+import com.google.devtools.build.lib.packages.AttributeTransitionData;
 import com.google.devtools.build.lib.packages.NoSuchTargetException;
 import com.google.devtools.build.lib.packages.Package;
-import com.google.devtools.build.lib.packages.RuleTransitionData;
 import com.google.devtools.build.lib.testutil.TestRuleClassProvider;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -269,9 +269,9 @@
                   .mandatory()
                   .allowedFileTypes()
                   .cfg(
-                      new TransitionFactory<RuleTransitionData>() {
+                      new TransitionFactory<AttributeTransitionData>() {
                         @Override
-                        public SplitTransition create(RuleTransitionData data) {
+                        public SplitTransition create(AttributeTransitionData data) {
                           return (BuildOptions options) -> {
                             String define = data.attributes().get("define", STRING);
                             BuildOptions newOptions = options.clone();

src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java b/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
index b0320d2..82d6b85 100644
--- a/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
+++ b/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
@@ -283,7 +283,8 @@
     Attribute attr = attr("foo", LABEL).cfg(splitTransition).allowedFileTypes().build();
     assertThat(attr.hasSplitConfigurationTransition()).isTrue();
     ConfigurationTransition transition =
-        attr.getTransitionFactory().create(RuleTransitionData.create(FakeAttributeMapper.empty()));
+        attr.getTransitionFactory()
+            .create(AttributeTransitionData.create(FakeAttributeMapper.empty()));
     assertThat(transition).isEqualTo(splitTransition);
   }
 
@@ -294,7 +295,8 @@
         attr("foo", LABEL).cfg(splitTransitionProvider).allowedFileTypes().build();
     assertThat(attr.hasSplitConfigurationTransition()).isTrue();
     ConfigurationTransition transition =
-        attr.getTransitionFactory().create(RuleTransitionData.create(FakeAttributeMapper.empty()));
+        attr.getTransitionFactory()
+            .create(AttributeTransitionData.create(FakeAttributeMapper.empty()));
     assertThat(transition).isInstanceOf(TestSplitTransition.class);
   }
 
@@ -314,9 +316,9 @@
   }
 
   private static class TestSplitTransitionProvider
-      implements TransitionFactory<RuleTransitionData> {
+      implements TransitionFactory<AttributeTransitionData> {
     @Override
-    public SplitTransition create(RuleTransitionData data) {
+    public SplitTransition create(AttributeTransitionData data) {
       return new TestSplitTransition();
     }