commit 2fb330016381848460fcd72f17f7072e6072cb2f
author twerth <twerth@google.com> Mon Oct 01 06:59:41 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Mon Oct 01 07:01:10 2018 -0700
tree a458646ce882d1f791f7c87c98573e9e1bc2b2a0
parent 5184cb79e008fb67e471d7cabe15e6f01c259d55

Add more profiling information.

RELNOTES: None
PiperOrigin-RevId: 215207309

src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
index aa6b262..bcac1c4 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
@@ -55,6 +55,8 @@
 import com.google.devtools.build.lib.pkgcache.PackageCacheOptions;
 import com.google.devtools.build.lib.pkgcache.PathPackageLocator;
 import com.google.devtools.build.lib.profiler.AutoProfiler;
+import com.google.devtools.build.lib.profiler.Profiler;
+import com.google.devtools.build.lib.profiler.SilentCloseable;
 import com.google.devtools.build.lib.skyframe.AspectValue.AspectKey;
 import com.google.devtools.build.lib.skyframe.DirtinessCheckerUtils.BasicFilesystemDirtinessChecker;
 import com.google.devtools.build.lib.skyframe.DirtinessCheckerUtils.ExternalDirtinessChecker;
@@ -302,7 +304,9 @@
     }
     super.sync(eventHandler, packageCacheOptions, skylarkSemanticsOptions, outputBase,
         workingDirectory, defaultsPackageContents, commandId, clientEnv, tsgm, options);
-    handleDiffs(eventHandler, packageCacheOptions.checkOutputFiles, options);
+    try (SilentCloseable c = Profiler.instance().profile("handleDiffs")) {
+      handleDiffs(eventHandler, packageCacheOptions.checkOutputFiles, options);
+    }
   }
 
   /**
@@ -486,17 +490,18 @@
     logger.info(
         "About to scan skyframe graph checking for filesystem nodes of types "
             + Iterables.toString(fileTypesToCheck));
-    Differencer.Diff diff =
-        fsvc.getDirtyKeys(
-            memoizingEvaluator.getValues(),
-            new UnionDirtinessChecker(
-                Iterables.concat(
-                    customDirtinessCheckers,
-                    ImmutableList.<SkyValueDirtinessChecker>of(
-                        new ExternalDirtinessChecker(
-                            tmpExternalFilesHelper,
-                            fileTypesToCheck),
-                        new MissingDiffDirtinessChecker(diffPackageRootsUnderWhichToCheck)))));
+    Differencer.Diff diff;
+    try (SilentCloseable c = Profiler.instance().profile("fsvc.getDirtyKeys")) {
+      diff =
+          fsvc.getDirtyKeys(
+              memoizingEvaluator.getValues(),
+              new UnionDirtinessChecker(
+                  Iterables.concat(
+                      customDirtinessCheckers,
+                      ImmutableList.<SkyValueDirtinessChecker>of(
+                          new ExternalDirtinessChecker(tmpExternalFilesHelper, fileTypesToCheck),
+                          new MissingDiffDirtinessChecker(diffPackageRootsUnderWhichToCheck)))));
+    }
     handleChangedFiles(diffPackageRootsUnderWhichToCheck, diff);
 
     for (Pair<Root, DiffAwarenessManager.ProcessableModifiedFileSet> pair :