| commit | 3312f4ebc62eecb74f366311cde15ffef16f5ae7 | [log] [tgz] |
|---|---|---|
| author | Googler <brandjon@google.com> | Mon Sep 30 10:55:51 2024 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Sep 30 10:57:41 2024 -0700 |
| tree | f28ffc88690cf003737de13b633e6de8fea59496 | |
| parent | b38703665f1324b04ce12d4a84443077510f8ee4 [diff] |
Apply select() promotion to Nones
Previously we did not apply `select()` promotion if the attribute value was `None`, which occurs as the Starlark representation of the default value for certain types (most notably `attr.label()`). But this is inconsistent. The same argument for general `select()` promotion -- that you fail fast and find errors sooner -- applies here. For instance, the macro author might have written code that passes when the argument is `None` but not when it is `select("//conditions:default", None)`.
Fixing this exposed a weakness in `copyAndLiftStarlarkValue()`, that it did not handle Nones correctly. (This was probably why I avoided select() promotion in this case to begin with.)
Work toward #19922.
PiperOrigin-RevId: 680640681
Change-Id: I6983bc3e44d3cf629c40c6014a2873b6c62e8841
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
