commit 32d2edc76b663545b10348036d5b1c22786f1c96
author tomlu <tomlu@google.com> Wed Nov 08 18:14:23 2017 +0100
committer Damien Martin-Guillerez <dmarting@google.com> Wed Nov 08 19:04:06 2017 +0100
tree a86cc6500bbb5d777836efab7657a77112598580
parent 74e4d31328b39fe427f223802d85656c1fa15d58

Remove least important argument to 5+ arg Preconditions#checkState/checkNotNull.

This change prepares a move to Guava's preconditions. Guava only has vararg-avoiding overloads up to 4 args.

PiperOrigin-RevId: 175015502

src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java b/src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java
index bcd7bfd..7760ca8 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java
@@ -212,72 +212,64 @@
         case CHECK:
           Preconditions.checkState(
               reverseDepsAsSet.contains(key),
-              "Reverse dep not present: %s %s %s %s %s",
+              "Reverse dep not present: %s %s %s %s",
               keyToConsolidate,
               reverseDepsAsSet,
-              newData,
               dataToConsolidate,
               entry);
           Preconditions.checkState(
               newData.add(key),
-              "Duplicate new reverse dep: %s %s %s %s %s",
+              "Duplicate new reverse dep: %s %s %s %s",
               keyToConsolidate,
               reverseDepsAsSet,
-              newData,
               dataToConsolidate,
               entry);
           break;
         case REMOVE:
           Preconditions.checkState(
               reverseDepsAsSet.remove(key),
-              "Reverse dep to be removed not present: %s %s %s %s %s",
+              "Reverse dep to be removed not present: %s %s %s %s",
               keyToConsolidate,
               reverseDepsAsSet,
-              newData,
               dataToConsolidate,
               entry);
           Preconditions.checkState(
               newData.remove(key),
-              "Reverse dep to be removed not present: %s %s %s %s %s",
+              "Reverse dep to be removed not present: %s %s %s %s",
               keyToConsolidate,
               reverseDepsAsSet,
-              newData,
               dataToConsolidate,
               entry);
           break;
         case REMOVE_OLD:
           Preconditions.checkState(
               reverseDepsAsSet.remove(key),
-              "Reverse dep to be removed not present: %s %s %s %s %s",
+              "Reverse dep to be removed not present: %s %s %s %s",
               keyToConsolidate,
               reverseDepsAsSet,
-              newData,
               dataToConsolidate,
               entry);
           Preconditions.checkState(
               !newData.contains(key),
-              "Reverse dep shouldn't have been added to new: %s %s %s %s %s",
+              "Reverse dep shouldn't have been added to new: %s %s %s %s",
               keyToConsolidate,
               reverseDepsAsSet,
-              newData,
               dataToConsolidate,
               entry);
           break;
         case ADD:
           Preconditions.checkState(
               reverseDepsAsSet.add(key),
-              "Duplicate reverse deps: %s %s %s %s %s",
+              "Duplicate reverse deps: %s %s %s %s",
               keyToConsolidate,
               reverseDeps,
-              newData,
               dataToConsolidate,
               entry);
           Preconditions.checkState(
               newData.add(key),
-              "Duplicate new reverse deps: %s %s %s %s %s",
+              "Duplicate new reverse deps: %s %s %s %s",
               keyToConsolidate,
               reverseDeps,
-              newData,
               dataToConsolidate,
               entry);
           break;