| commit | 33e8a7ddbc0d634831a2a6298511437830846d53 | [log] [tgz] |
|---|---|---|
| author | leba <leba@google.com> | Tue Jun 02 02:30:01 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jun 02 02:31:13 2020 -0700 |
| tree | 0347e3cc026836aeb1437666a30fb62c2813ae09 | |
| parent | 0ff9f3aa65850b00531fea19f145703d7e19fff0 [diff] |
Fix error reporting omission. The problem with error reporting was caused by: - The error being printed to stderr in ActionExecutionFunction#checkCacheAndExecuteIfNeeded - ActionExecutionFunction#accumulateInputs of a higher-level action throws ActionExecutionException and halts the evaluation before lower-level actions that are covered by ArtifactNestedSetKeys have the chance to be evaluated by Skyframe (hence printing their errors). To fix this, we need to make sure the transitive ArtifactNestedSetKeys get evaluated i.e. checking env.valuesMissing in ActionExecutionFunction after evaluating the inputs. However, checking for missing values should only be done after the handling of all exceptions (if any). This CL refactors accumulateInputs to separate the error-handling portion from the input-accumulation portion. We can then check for missing values after handling the exceptions (if any), and before accessing the NSOS map for input accumulation. Significant changes: - New ArtifactNestedSetEvalException: bundles together individual exceptions from children, to be handled in ActionExecutionFunction. - Refactoring of accumulateInputs: separate error-handling and input-accumulation. - The NSOS map now no longer hold ValueOrException but instead: Map<SkyKey, SkyValue> This change is flag-guarded behind --experimental_nsos_eval_keys_as_one_group. RELNOTES: None PiperOrigin-RevId: 314293281
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
