commit 344449d48359ba6d9190d271a6a937758abb685c
author Googler <noreply@google.com> Thu Sep 15 18:25:35 2016 +0000
committer Dmitry Lomov <dslomov@google.com> Fri Sep 16 07:59:22 2016 +0000
tree 235220381007e2f2d7dac13d03d5c60d24c1585b
parent dfad9e312d3a2aae837369cbec6eef40f7bf6b92

Fix formatMethod() when all arguments are named

Previously an error might look like:

  Type PackagingCommon has no function directory(Label labelstring pathint mode).

Now, it shows up correctly as:

  Type PackagingCommon has no function directory(Label label, string path, int mode).

--
MOS_MIGRATED_REVID=133285688

src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java b/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java
index 5c8f13a..49f85f0 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java
@@ -505,6 +505,7 @@
       sb.append(EvalUtils.getDataTypeName(kwarg.getValue()));
       sb.append(" ");
       sb.append(kwarg.getKey());
+      first = false;
     }
     return sb.append(")").toString();
   }