| commit | 62475e738f1206a06dbda0d2638015c2c2fb1c88 | [log] [tgz] |
|---|---|---|
| author | bnczk <32466429+bnczk@users.noreply.github.com> | Mon Aug 03 05:14:58 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Aug 03 05:16:09 2020 -0700 |
| tree | a21801e8a7a5daa9362638b30c5bc5fce376f4ff | |
| parent | dd1d8419eeed402f10c13220c562c8c9dd653f11 [diff] |
Add units to --remote_timeout Implements #7224. Maintains backwards compatibility by allowing unit-less values, defaulting to seconds. Open issues are these Int casts [here](https://github.com/bazelbuild/bazel/compare/master...bnczk:remote-timeout-units?expand=1#diff-2f15328ea07078b2109edd1d4e288c82R111) and [here](https://github.com/bazelbuild/bazel/compare/master...bnczk:remote-timeout-units?expand=1#diff-2f15328ea07078b2109edd1d4e288c82R123). As the netty channel in `HttpCacheClient` only accepts ints as millisecond timeout, this cast is necessary as `Duration` returns a long. We could either - don't use `Duration`, only `int` directly (still exposes an overflow as the current implementation of `HttpCacheClient` multiplies the seconds by 1000 to get milliseconds) - let the converter check if the `long` to `int` conversion throws an exception and throw an explicit `OptionsParsingException` - allow it to fail during the cast Closes #11713. PiperOrigin-RevId: 324584686
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
