Intern only `Object[]` children in `NestedSetInterner` to restore determinism. `Depset` equality and hashing delegate directly to the underlying `NestedSet` instance's identity. Because `NestedSetInterner` previously interned entire `NestedSet` instances in a bounded cache, `depset` comparisons and set/dict operations in Starlark were non-deterministic depending on whether a `depset` construction resulted in a cache hit or miss (b/544770151). To fix this, we update `NestedSetInterner` to intern only the backing `Object[]` children arrays rather than the enclosing `NestedSet` instances. This intentionally sacrifices some memory savings in order to restore determinism to `Depset` instance equality and hashing. It is possible that the size bounds in `NestedSetInterner` can be tuned because we are no longer interning singletons. However, I am leaving that out of this change. Added unit tests verifying that `Depset` equality and hashing are deterministic across interner cache states. Includes the following cleanups: - Handle identity interning for all `StarlarkValue` types directly at `NestedSet` construction time, eliminating the need for `internDepset`. - Remove the now-redundant `IsArtifactForNestedSet` interface since `Artifact` is already a `StarlarkValue`. PiperOrigin-RevId: 966554823 Change-Id: Iffb3a0356fd2bb62c797d7ace0292f4437c9b44d
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
