commit 389142468f72a16b6f21c35c20c9084eb85c504d
author nharmata <nharmata@google.com> Wed Aug 02 21:39:06 2017 +0200
committer Dmitry Lomov <dslomov@google.com> Thu Aug 03 12:09:58 2017 +0200
tree 4bfc060cdef2bea9a270f1c9ad170e3972d6aea2
parent 2714195feae97333bca4ef0896c416f5f07b2f92

Don't unconditionally call PathFragment#normalize in the PackageIdentifier ctor. This is completely wasteful in the common case of the PathFragment already being normalized.

RELNOTES: None
PiperOrigin-RevId: 164022960

src/main/java/com/google/devtools/build/lib/cmdline/PackageIdentifier.java

diff --git a/src/main/java/com/google/devtools/build/lib/cmdline/PackageIdentifier.java b/src/main/java/com/google/devtools/build/lib/cmdline/PackageIdentifier.java
index e276793..f99bf9a 100644
--- a/src/main/java/com/google/devtools/build/lib/cmdline/PackageIdentifier.java
+++ b/src/main/java/com/google/devtools/build/lib/cmdline/PackageIdentifier.java
@@ -111,8 +111,10 @@
 
   private PackageIdentifier(RepositoryName repository, PathFragment pkgName) {
     this.repository = Preconditions.checkNotNull(repository);
-    this.pkgName = Canonicalizer.fragments().intern(
-            Preconditions.checkNotNull(pkgName).normalize());
+    if (!pkgName.isNormalized()) {
+      pkgName = pkgName.normalize();
+    }
+    this.pkgName = Canonicalizer.fragments().intern(Preconditions.checkNotNull(pkgName));
     this.hashCode = Objects.hash(repository, pkgName);
   }