commit 39014167557d0eb2c2f140e9a48a753e1200e9c2
author László Csomor <laszlocsomor@google.com> Wed Mar 15 11:05:20 2017 +0100
committer László Csomor <laszlocsomor@google.com> Wed Mar 15 16:45:31 2017 +0100
tree b9112e3fa13770cadfdab385fe536e477cc1c83e
parent eb46bedecfb54584905b800a493962351a4c0a51

gRPC, Windows: add missing #include and warning

Add a missing header inclusion to string_win32.c
which was resulting in an implicit function
declaration with the wrong, but compatible type,
causing a char* being converted to int, converted
to char*, corrupting the upper 32 bits, leading to
a segfault.

Fixes https://github.com/bazelbuild/bazel/issues/2672

Change-Id: I805737c93c248f792b2c0f54fe15ab9a261575d2

third_party/grpc/BUILD

diff --git a/third_party/grpc/BUILD b/third_party/grpc/BUILD
index deaefd0..864d93c 100644
--- a/third_party/grpc/BUILD
+++ b/third_party/grpc/BUILD
@@ -414,7 +414,7 @@
     ],
     copts = [
         "-std=gnu99",
-        "-Wno-implicit-function-declaration",
+        "-Wimplicit-function-declaration",
     ],
     includes = [
         ".",

third_party/grpc/src/core/support/string_win32.c

diff --git a/third_party/grpc/src/core/support/string_win32.c b/third_party/grpc/src/core/support/string_win32.c
index 3b1f702c..aedc987 100644
--- a/third_party/grpc/src/core/support/string_win32.c
+++ b/third_party/grpc/src/core/support/string_win32.c
@@ -34,6 +34,7 @@
 /* Posix code for gpr snprintf support. */
 
 #include <grpc/support/port_platform.h>
+#include <grpc/support/string_util.h>
 
 #ifdef GPR_WIN32