| commit | 3992d29f23b469df8f1cfc0cc707d0058ceede3e | [log] [tgz] |
|---|---|---|
| author | laurentlb <laurentlb@google.com> | Fri Mar 22 13:35:12 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Mar 22 13:36:59 2019 -0700 |
| tree | 95a36b8b6921f00d81823ad6cfb564fdb322648a | |
| parent | d6cd9176fcfd3e218edc653cdcb94eebca180332 [diff] |
Enable --incompatible_bzl_disallow_load_after_statement by default Fixes https://github.com/bazelbuild/bazel/issues/5815 Tested: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/49 RELNOTES: --incompatible_bzl_disallow_load_after_statement is enabled PiperOrigin-RevId: 239854652
diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index f8e6a94..88b137b 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java
@@ -154,7 +154,7 @@ @Option( name = "incompatible_bzl_disallow_load_after_statement", - defaultValue = "false", + defaultValue = "true", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS}, metadataTags = {
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java index 7485233..54c36e1 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java
@@ -212,7 +212,7 @@ .experimentalRestrictNamedParams(false) .experimentalStarlarkConfigTransitions(false) .incompatibleUseToolchainProvidersInJavaCommon(false) - .incompatibleBzlDisallowLoadAfterStatement(false) + .incompatibleBzlDisallowLoadAfterStatement(true) .incompatibleDepsetIsNotIterable(false) .incompatibleDepsetUnion(false) .incompatibleDisableThirdPartyLicenseChecking(false)