commit 3ab82f767981c5bb32e041a3d08b8dc9f41625e2
author Ulf Adams <ulfjack@google.com> Fri Sep 04 12:10:53 2015 +0000
committer Dmitry Lomov <dslomov@google.com> Fri Sep 04 12:53:08 2015 +0000
tree 6c31f94248a8bd7dffca0564e08670f11a2e177a
parent b7a69e551e4da9f8a4f7a4649c7843044d122732

Fix some warnings.

--
MOS_MIGRATED_REVID=102332437

src/main/java/com/google/devtools/build/lib/packages/Package.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/Package.java b/src/main/java/com/google/devtools/build/lib/packages/Package.java
index 1cd3635..92a24fb 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/Package.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/Package.java
@@ -768,7 +768,7 @@
     /**
      * The output instance for this builder. Needs to be instantiated and
      * available with name info throughout initialization. All other settings
-     * are applied during {@link #build}. See {@link Package#Package(String)}
+     * are applied during {@link #build}. See {@link Package#Package(PackageIdentifier)}
      * and {@link Package#finishInit} for details.
      */
     protected Package pkg;

src/main/java/com/google/devtools/build/lib/packages/RuleClass.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
index ddbda14..59fcbb5 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
@@ -191,7 +191,7 @@
         @Override
         public String getCategory() {
           return "core";
-        };
+        }
   };
 
   /**

src/main/java/com/google/devtools/build/lib/packages/RuleFactory.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleFactory.java b/src/main/java/com/google/devtools/build/lib/packages/RuleFactory.java
index 485bfa8..33f9d49 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/RuleFactory.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/RuleFactory.java
@@ -79,7 +79,7 @@
       FuncallExpression ast,
       Location location,
       ImmutableList<StackTraceElement> stackTrace)
-      throws InvalidRuleException, NameConflictException {
+      throws InvalidRuleException {
     Preconditions.checkNotNull(ruleClass);
     String ruleClassName = ruleClass.getName();
     Object nameObject = attributeValues.get("name");
@@ -127,7 +127,7 @@
       EventHandler eventHandler,
       FuncallExpression ast,
       Location location)
-      throws InvalidRuleException, NameConflictException {
+      throws InvalidRuleException {
     return createRule(pkgBuilder, ruleClass, attributeValues, eventHandler, ast, location,
         ImmutableList.<StackTraceElement>of());
   }